Properly cleanup when the Widget is initialized by an implicit `as_widget()` #195

cpsievert · 2025-05-21T22:42:19Z

#191 introduced a problem where, if the widget that is initialized by an internal as_widget() call, then it doesn't get cleaned up.

For a minimal reprex of the issue, notice how clicking the button will keep inserting new plots

import plotly.express as px
from shiny.express import input, ui

from shinywidgets import render_plotly

ui.input_action_button("redraw", "Redraw")

@render_plotly
def plot():
    input.redraw()
    return px.histogram(
        px.data.tips(),
        x="total_bill",
    )

…get() call

cpsievert added 2 commits May 21, 2025 17:34

Properly cleanup when the Widget is initialized by an implicit as_wid…

234c666

…get() call

Update changelog

cc098ac

cpsievert merged commit 212acf8 into main May 21, 2025
5 checks passed

cpsievert deleted the fix/as-widget-cleanup branch May 21, 2025 22:46

cpsievert mentioned this pull request May 21, 2025

Eliminate the possibility of a single render_widget output from keeping a view of prior renders #196

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly cleanup when the Widget is initialized by an implicit `as_widget()` #195

Properly cleanup when the Widget is initialized by an implicit `as_widget()` #195

cpsievert commented May 21, 2025 •

edited

Loading

Properly cleanup when the Widget is initialized by an implicit as_widget() #195

Properly cleanup when the Widget is initialized by an implicit as_widget() #195

Conversation

cpsievert commented May 21, 2025 • edited Loading

Properly cleanup when the Widget is initialized by an implicit `as_widget()` #195

Properly cleanup when the Widget is initialized by an implicit `as_widget()` #195

cpsievert commented May 21, 2025 •

edited

Loading